refactor: park the MAVLink 2 bridge out of the tree - #3159
Conversation
A domain-specific protocol bridge — one MAVLink dialect, one autopilot ecosystem, ~2 months old at the freeze — is a poor thing to commit to semver for the life of 1.x. Moves it to external/dora-mavlink2/, staged for its own repository, and drops it from the workspace. Unlike the memory-pool extraction this is not an entanglement warning: MAVLink touched dora only through the public node API. Removing it changed no dora source file outside the workspace manifest and the smoke harness, so reinstating it needs a repo and a release, not a new seam. Moves bridge, bridge-node, and both example dirs; drops 5 workspace members, the `dora-mavlink2-bridge` and `mavlink` workspace deps, and the `mavlink2-bridge-cxx` example target; removes 4 smoke tests and the smoke-all.sh entries. The parked crates are listed under `[workspace] exclude` so cargo ignores them. external/dora-mavlink2/README.md records the dependency spec, the fixed-port (udp:14550) smoke caveat, and the `deny.toml` / `_typos.toml` entries deliberately left behind. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
🤖 Automated review by Claude — fully automated review; no human has verified these findings. No issues found. Checked: this is a pure park/move refactor — every relocated source file is a 100%-similarity rename into Generated by Claude Code |
|
We want to keep in in tree. |
1 participant
A domain-specific protocol bridge — one MAVLink dialect, one autopilot ecosystem, roughly two months old at the freeze — is a poor thing to commit to semver for the life of 1.x. This moves it to
external/dora-mavlink2/, staged for its own repository, and drops it from the workspace. Same parking convention as the memory-pool extraction.Unlike that one, this is not an entanglement warning. MAVLink touched dora only through the public node API: removing it changed no dora source file outside the workspace manifest and the smoke harness. The seam already exists, so reinstating it needs a repository and a release, not a redesign.
external/dora-mavlink2/README.mdsays exactly that, and records themavlinkdependency spec, the fixed-port (udp:14550) smoke caveat, and thedeny.toml/_typos.tomlentries deliberately left behind.What moves:
libraries/extensions/mavlink2-bridge,binaries/mavlink2-bridge-node, and both example directories.What's dropped: 5 workspace members, the
dora-mavlink2-bridgeandmavlinkworkspace dependencies, themavlink2-bridge-cxxexample target, 4 smoke tests, and thescripts/smoke-all.shentries. The parked crates are listed under[workspace] excludeso cargo ignores them rather than warning.No dora crate depended on it, so nothing else changes.